refactor: pull header & wallet components out of Swap component #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kristiehuang
changed the title
3 tasks
JFrankfurt
approved these changes
Aug 3, 2022
zzmp
suggested changes
Aug 12, 2022
| <Row gap={1}>{children}</Row> | ||
| <Row gap={0.5}> | ||
| <ThemedText.Subhead1> | ||
| <Trans>Swap</Trans> |
There was a problem hiding this comment.
Should widgets expand past Swap, this will need to be configurable.
Can you keep passing title into the header?
| @@ -14,11 +15,12 @@ export type { DefaultAddress, TokenDefaults } from 'hooks/swap/useSyncTokenDefau | |||
| export type { Theme } from 'theme' | |||
| export { darkTheme, defaultTheme, lightTheme } from 'theme' | |||
|
|
|||
| export type SwapWidgetProps = SwapProps & WidgetProps | |||
| export type SwapWidgetProps = HeaderProps & SwapProps & WidgetProps | |||
There was a problem hiding this comment.
This should be an interface extending the existing props:
export interface SwapWidgetProps extends HeaderProps, SwapProps, WidgetProps {}
This is slightly easier on the type system: it reduces time for type checking and it surfaces better types downstream.
| const onSupportedNetwork = useOnSupportedNetwork() | ||
| const isDisabled = !(isActive && onSupportedNetwork) | ||
|
|
||
| const [onConnectWalletClick, setOnConnectWalletClick] = useAtom(onConnectWalletClickAtom) |
There was a problem hiding this comment.
You should be able to set this without referencing the already-set value:
const setOnConnectWalletClick = useSetAtom(onConnectWalletClickAtom)
useEffect(() => setOnConnectWalletClick(props.onConnectWalletClick), [props.onConnectWalletClick, setOnConnectWalletClick])
| </Row> | ||
| <Row gap={1}> | ||
| <Wallet disabled={props.hideConnectionUI} /> | ||
| <Settings disabled={isDisabled} /> |
There was a problem hiding this comment.
Settings is specific to the Swap widget (similar to the title) - this either needs to be a prop, or a callback to activate the Swap's settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wallet connection + swap are two separate concerns, so should be two separate components imo
Refactoring to pull wallet out of the swap component